[FFmpeg-devel] [PATCH] avcodec/h264dec: get field_order for typical frames

[Michael Niedermayer]

On Wed, Dec 05, 2018 at 08:38:41PM +0100, Paul B Mahol wrote:
> On 12/5/18, Michael Niedermayer <michael at niedermayer.cc> wrote:
> > On Wed, Dec 05, 2018 at 12:42:39PM +0100, Paul B Mahol wrote:
> >> This is normally set by parser but parsing is not always enabled.
> >>
> >> Signed-off-by: Paul B Mahol <onemda at gmail.com>
> >> ---
> >>  libavcodec/h264dec.c | 18 ++++++++++++++++++
> >>  1 file changed, 18 insertions(+)
> >
> > breaks: fate-api-h264-slice
> > make: *** [fate-api-h264-slice] Error 139
> 
> How so? Do you know why?

thats what valgrind says:

==16920== Invalid read of size 4
==16920==    at 0x51ED49: h264_decode_frame (h264dec.c:1022)
==16920==    by 0x473A1C: decode_simple_internal (decode.c:433)
==16920==    by 0x4746A3: decode_simple_receive_frame (decode.c:629)
==16920==    by 0x47476E: decode_receive_frame_internal (decode.c:647)
==16920==    by 0x4749C9: avcodec_send_packet (decode.c:705)
==16920==    by 0x408ACA: decode (api-h264-slice-test.c:57)
==16920==    by 0x409268: main (api-h264-slice-test.c:211)
==16920==  Address 0x488 is not stack'd, malloc'd or (recently) free'd
==16920== 
==16920== 
==16920== Process terminating with default action of signal 11 (SIGSEGV)
==16920==  Access not within mapped region at address 0x488
==16920==    at 0x51ED49: h264_decode_frame (h264dec.c:1022)
==16920==    by 0x473A1C: decode_simple_internal (decode.c:433)
==16920==    by 0x4746A3: decode_simple_receive_frame (decode.c:629)
==16920==    by 0x47476E: decode_receive_frame_internal (decode.c:647)
==16920==    by 0x4749C9: avcodec_send_packet (decode.c:705)
==16920==    by 0x408ACA: decode (api-h264-slice-test.c:57)
==16920==    by 0x409268: main (api-h264-slice-test.c:211)

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have never wished to cater to the crowd; for what I know they do not
approve, and what they approve I do not know. -- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20181206/e6d79f7a/attachment.sig>