[FFmpeg-devel] [PATCH]lsws/utils: Split "emms_c(); " call in two lines

[Michael Niedermayer]

On Mon, Dec 17, 2018 at 02:14:26AM +0100, Carl Eugen Hoyos wrote:
> Hi!
> 
> Attached patch fixes a useless warning when compiling with clang on arm.
> 
> Please comment, Carl Eugen

>  utils.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> fb6799bbc59d79d9dfba9f8661aaecbed568f3a5  0001-lsws-utils-Split-emms_c-in-two-lines.patch
> From b2773d1ca9473380b99400c2bbd5a6729622f51a Mon Sep 17 00:00:00 2001
> From: Carl Eugen Hoyos <ceffmpeg at gmail.com>
> Date: Mon, 17 Dec 2018 02:12:13 +0100
> Subject: [PATCH] lsws/utils: Split "emms_c();" in two lines.
> 
> Silences a clang warning when not compiling for x86:
> libswscale/utils.c:345:13: warning: while loop has empty body
> ---
>  libswscale/utils.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/libswscale/utils.c b/libswscale/utils.c
> index df68bcc..de64694 100644
> --- a/libswscale/utils.c
> +++ b/libswscale/utils.c
> @@ -342,7 +342,8 @@ static av_cold int initFilter(int16_t **outFilter, int32_t **filterPos,
>      const int64_t fone = 1LL << (54 - FFMIN(av_log2(srcW/dstW), 8));
>      int ret            = -1;
>  
> -    emms_c(); // FIXME should not be required but IS (even for non-MMX versions)
> +    emms_c() // FIXME should not be required but IS (even for non-MMX versions)
> +        ;

this looks like a bad change that could confuse people
i think a different solution should be found or the warning left if theres none

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have never wished to cater to the crowd; for what I know they do not
approve, and what they approve I do not know. -- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20181217/5411c079/attachment.sig>