[FFmpeg-devel] [PATCH 1/2] add support for ROI-based encoding

[Carl Eugen Hoyos]

2018-12-21 17:36 GMT+01:00, Derek Buitenhuis <derek.buitenhuis at gmail.com>:

> On 12/12/2018 16:26, Guo, Yejun wrote:
>> +        if (frame->rois_buf != NULL) {
>> +            if (x4->params.rc.i_aq_mode == X264_AQ_NONE) {
>> +                av_log(ctx, AV_LOG_ERROR, "Adaptive quantization
>> must be enabled to use ROI encoding, skipping ROI.\n");
>
> This should, in my opinion, return an error and fail hard.

> If people want it to continue anyway, it should be AV_LOG_WARNING.

+1

Carl Eugen