[FFmpeg-devel] [PATCH 4/4] zmbvenc: use unsigned values for score calculations

[Tomas Härdin]

lör 2018-12-22 klockan 15:54 +0000 skrev Matthew Fearnley:
> > On 22 Dec 2018, at 12:15, Tomas Härdin <tjoppen at acc.umu.se> wrote:
> > 
> > tor 2018-12-20 klockan 17:48 +0000 skrev Matthew Fearnley:
> > > > > > On Thu, 20 Dec 2018 at 16:30, Tomas Härdin <tjoppen at acc.umu
> > > > > > .se> wrote:
> > > > 
> > > > Trivial enough. You could probably roll many or even all of
> > > > these
> > > > patches together
> > > 
> > > Thanks for your feedback.  I was reluctant to submit so many
> > > patches, but I
> > > worried at the time that combining them would require an overly
> > > long commit
> > > message.  Maybe I'm being too verbose though...
> > > What's the best way to submit a combined patch - from a
> > > Patchwork/mailing
> > > list perspective?
> > 
> > How large a patch should be is somewhat arbitrary. I tend to try to
> > keep each patch related to a single "concept". And of course
> > separating
> > cosmetic and functional changes
> > 
> > It's mostly the having to have PATCH 3/4 before PATCH 1/4 prompting
> > this suggestion. Or maybe rolling them together
> 
> If I roll the patches together (and include the additional
> suggestions in PATCH 1), would it be best to just email a new patch,
> and have these closed?

If you have a new set of patches then a new thread is best, yes

/Tomas