[FFmpeg-devel] [PATCH] Add a new channel layout API

[Nicolas George]

Paul B Mahol (2018-12-30):
> >> Input #0, wv, from
> >> '/home/computer/Downloads/Run_The_Race_-_3rd_Order_Ambisonic_SN3D.wv':
> >>   Duration: 00:11:07.67, start: 0.000000, bitrate: 6084 kb/s
> >>     Stream #0:0: Audio: wavpack, 44100 Hz, 16 channels
> >> (FL+FR+FC+LFE+BL+BR+FLC+FRC+BC+SL+SR+TC+TFL+TFC+TFR+TBL), s16p
> >
> > Yes... and...?
> 
> From this is obvious that user can not use '+' to separate channel
> layouts if it is already used to define channel layouts.
> 
> Do you need better explanation now?

Well, quoting the original patch:

+ * The input string can be represented by:
+ *  - the formal channel layout name (returned by av_channel_layout_describe())
+ *  - single or multiple channel names (returned by av_channel_name()
+ *    or concatenated with "|")
+ *  - a hexadecimal value of a channel layout (eg. "0x4")
+ *  - the number of channels with default layout (eg. "5")
+ *  - the number of unordered channels (eg. "4 channels")

There is no mention about '+'. So I guess this paragraph needs to be
rewritten to actually match what is being done.

And if + is not possible, | is still a bad choice. Use a character that
is not special for standard shells, I am sure we can find some; maybe /.

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20181230/0c5285d9/attachment.sig>