[FFmpeg-devel] [PATCH] libavfilter: constify filter list

[Muhammad Faiz]

On Thu, Feb 1, 2018 at 5:03 PM, Nicolas George <george at nsup.org> wrote:
> Hi.
>
> Muhammad Faiz (2018-01-30):
>> Move REGISTER_FILTER to FILTER_TABLE in configure.
>> Auto generate filter extern and filter table.
>> Sort filter table, use bsearch on avfilter_get_by_name.
>> Define next pointer at filter extern, no need to initialize
>> next pointer at run time, so AVFilter can be set to const.
>> Make avfilter_register always return error.
>> Target checkasm now depends on EXTRALIBS-avformat.
>
> Regarding registering user filters, do not bother about that. That ship
> has sailed a long time ago; it is already more than half-way across and
> decelerating. If somebody wants to implement plugins, they will have a
> lot of work. Designing a way of registering user filters so that they
> can be parsed by name would be a spoonful in the pool.
>
> Regarding the actual implementation:
>
> I do not like that you moved the list into configure. Not per se, but
> because it is completely different from what Josh de Kock is doing with
> codecs, parsers and formats. Please coordinate with Josh to have a
> consistent solution for all components.

Actually I have a plan to sort codecs based on name and codec_id. And
it is difficult to sort based on codec_id with only extern declaration
in allcodecs.


>
> I think the fact that you need to insert a line in each filter is rather
> a sign that the design is far from perfect.

I remove it in my new patch.

>
> Regarding the efficiency of avfilter_next(), I think we should not care.
> Almost nobody uses that function outside lavfi anyway. If it proves a
> concern for some application, we can deal with it when it is found.


Thank's.