[FFmpeg-devel] [PATCH] avfilter: sort filter list

[Michael Niedermayer]

On Fri, Feb 02, 2018 at 01:29:54AM +0700, Muhammad Faiz wrote:
> Move REGISTER_FILTER to FILTER_TABLE in configure.
> Replace linked list with static table, and sort it.
> Use bsearch() on avfilter_get_by_name().
> Deprecate avfilter_register_all(), avfilter_register(), and
> avfilter_next().
> Add avfilter_iterate() as a replacement for avfilter_next().
> 
> Signed-off-by: Muhammad Faiz <mfcc64 at gmail.com>
> ---
>  Makefile                 |   5 +-
>  configure                | 428 ++++++++++++++++++++++++++++++++++++++++++++-
>  doc/APIchanges           |   4 +
>  libavfilter/allfilters.c | 441 ++++++-----------------------------------------
>  libavfilter/avfilter.c   |  65 ++-----
>  libavfilter/avfilter.h   |  20 ++-
>  libavfilter/buffersink.c |   4 +-
>  libavfilter/version.h    |  10 +-
>  tests/checkasm/Makefile  |   2 +-
>  9 files changed, 532 insertions(+), 447 deletions(-)

this seems breaking make fate-checkasm

./configure --enable-libsoxr && make fate-checkasm -j12
...
LD	tests/checkasm/checkasm
libswresample/libswresample.a(soxr_resample.o): In function `get_out_samples':
libswresample/soxr_resample.c:118: undefined reference to `soxr_delay'
libswresample/libswresample.a(soxr_resample.o): In function `get_delay':
libswresample/soxr_resample.c:100: undefined reference to `soxr_delay'
libswresample/libswresample.a(soxr_resample.o): In function `flush':
libswresample/soxr_resample.c:70: undefined reference to `soxr_delay'
libswresample/soxr_resample.c:72: undefined reference to `soxr_process'
libswresample/soxr_resample.c:77: undefined reference to `soxr_process'
libswresample/soxr_resample.c:78: undefined reference to `soxr_delay'
libswresample/libswresample.a(soxr_resample.o): In function `process':
libswresample/soxr_resample.c:88: undefined reference to `soxr_set_num_channels'
libswresample/soxr_resample.c:88: undefined reference to `soxr_set_error'
libswresample/soxr_resample.c:90: undefined reference to `soxr_process'
libswresample/libswresample.a(soxr_resample.o): In function `destroy':
libswresample/soxr_resample.c:65: undefined reference to `soxr_delete'
libswresample/libswresample.a(soxr_resample.o): In function `create':
libswresample/soxr_resample.c:46: undefined reference to `soxr_io_spec'
libswresample/soxr_resample.c:48: undefined reference to `soxr_quality_spec'
libswresample/soxr_resample.c:56: undefined reference to `soxr_delete'
libswresample/soxr_resample.c:57: undefined reference to `soxr_create'
collect2: error: ld returned 1 exit status
make: *** [tests/checkasm/checkasm] Error 1

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The worst form of inequality is to try to make unequal things equal.
-- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180202/65f5b6fb/attachment.sig>