[FFmpeg-devel] [PATCH v4 4/7] lavf: move fifo test muxer into separate file

[Marton Balint]

On Mon, 5 Feb 2018, Muhammad Faiz wrote:

> On Sat, Feb 3, 2018 at 2:44 AM, Josh de Kock <josh at itanimul.li> wrote:
>> This fixes the fate-fifo-muxer test.
>> ---
>>  libavformat/Makefile           |   2 +-
>>  libavformat/allformats.c       |   1 +
>>  libavformat/fifo_test.c        | 150 +++++++++++++++++++++++++++++++++++++++++
>>  libavformat/tests/fifo_muxer.c | 115 +------------------------------
>>  4 files changed, 154 insertions(+), 114 deletions(-)
>>  create mode 100644 libavformat/fifo_test.c
>>
>> diff --git a/libavformat/Makefile b/libavformat/Makefile
>> index de0de92..e0bb8ae 100644
>> --- a/libavformat/Makefile
>> +++ b/libavformat/Makefile
>> @@ -163,7 +163,7 @@ OBJS-$(CONFIG_EAC3_MUXER)                += rawenc.o
>>  OBJS-$(CONFIG_EPAF_DEMUXER)              += epafdec.o pcm.o
>>  OBJS-$(CONFIG_FFMETADATA_DEMUXER)        += ffmetadec.o
>>  OBJS-$(CONFIG_FFMETADATA_MUXER)          += ffmetaenc.o
>> -OBJS-$(CONFIG_FIFO_MUXER)                += fifo.o
>> +OBJS-$(CONFIG_FIFO_MUXER)                += fifo.o fifo_test.o

You should introduce a new config option for the test fifo muxer, we 
typically don't want to build it, so I'd say it should only be enabled if 
explicitly requested, or something like that.

(Can be done later as well as a separate patch, but it should be done).

Regards,
Marton