[FFmpeg-devel] [FFmpeg-cvslog] lavc: add new API for iterating codecs and codec parsers

[Michael Niedermayer]

On Wed, Feb 07, 2018 at 01:52:33PM +0100, Nicolas George wrote:
> Josh de Kock (2018-02-06):
> > ffmpeg | branch: master | Josh de Kock <josh at itanimul.li> | Fri Dec 22 22:17:00 2017 +0000| [7e8eba2d8755962d9dca5eade57bf8f591a73c0c] | committer: Josh de Kock
> > 
> > lavc: add new API for iterating codecs and codec parsers
> > 
> > Based on an unfinished patch by atomnuker.

This commit also breaks 

./configure --enable-libsoxr && make -j12 fate-checkasm
 make -j12 fate-checkasm
 ...
LD	tests/checkasm/checkasm
libswresample/libswresample.a(soxr_resample.o): In function `get_out_samples':
ffmpeg/libswresample/soxr_resample.c:118: undefined reference to `soxr_delay'
libswresample/libswresample.a(soxr_resample.o): In function `get_delay':
ffmpeg/libswresample/soxr_resample.c:100: undefined reference to `soxr_delay'
libswresample/libswresample.a(soxr_resample.o): In function `flush':
ffmpeg/libswresample/soxr_resample.c:70: undefined reference to `soxr_delay'
ffmpeg/libswresample/soxr_resample.c:72: undefined reference to `soxr_process'
ffmpeg/libswresample/soxr_resample.c:77: undefined reference to `soxr_process'
ffmpeg/libswresample/soxr_resample.c:78: undefined reference to `soxr_delay'
libswresample/libswresample.a(soxr_resample.o): In function `process':
ffmpeg/libswresample/soxr_resample.c:88: undefined reference to `soxr_set_num_channels'
ffmpeg/libswresample/soxr_resample.c:88: undefined reference to `soxr_set_error'
ffmpeg/libswresample/soxr_resample.c:90: undefined reference to `soxr_process'
libswresample/libswresample.a(soxr_resample.o): In function `destroy':
ffmpeg/libswresample/soxr_resample.c:65: undefined reference to `soxr_delete'
libswresample/libswresample.a(soxr_resample.o): In function `create':
ffmpeg/libswresample/soxr_resample.c:46: undefined reference to `soxr_io_spec'
ffmpeg/libswresample/soxr_resample.c:48: undefined reference to `soxr_quality_spec'
ffmpeg/libswresample/soxr_resample.c:56: undefined reference to `soxr_delete'
ffmpeg/libswresample/soxr_resample.c:57: undefined reference to `soxr_create'
collect2: error: ld returned 1 exit status
make: *** [tests/checkasm/checkasm] Error 1

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180208/94545e72/attachment.sig>