[FFmpeg-devel] [PATCH] avformat/opensrt: add Haivision Open SRT protocol
michael at niedermayer.cc
Fri Feb 9 16:10:55 EET 2018
On Fri, Feb 09, 2018 at 02:28:41PM +0100, wm4 wrote:
> On Fri, 9 Feb 2018 03:08:26 +0100
> Michael Niedermayer <michael at niedermayer.cc> wrote:
> > On Tue, Jan 30, 2018 at 04:11:03PM -0500, Nablet Developer wrote:
> > > protocol requires libsrt (https://github.com/Haivision/srt) to be
> > > installed
> > >
> > > Signed-off-by: Nablet Developer <sdk at nablet.com>
> > > ---
> > > MAINTAINERS | 1 +
> > > configure | 9 +
> > > doc/protocols.texi | 116 +++++++++
> > > libavformat/Makefile | 1 +
> > > libavformat/opensrt.c | 621 ++++++++++++++++++++++++++++++++++++++++++++++++
> > > libavformat/protocols.c | 1 +
> > > 6 files changed, 749 insertions(+)
> > > create mode 100644 libavformat/opensrt.c
> > >
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index ba7a728..0317f24 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -498,6 +498,7 @@ Protocols:
> > > http.c Ronald S. Bultje
> > > libssh.c Lukasz Marek
> > > mms*.c Ronald S. Bultje
> > > + opensrt.c Nablet Developer
> > > udp.c Luca Abeni
> > > icecast.c Marvin Scholz
> > Is "Nablet Developer" identifying a single person ?
> > if not this is not ok as the MAINTAINERS files gives one also the right to
> > have git write access and that would not work with a unspecified group
> I'd assume this is under the copyright of that nablet company. I'd
> advise against just giving some drive-by contributor git push
> access (who is probably multiple persons under a single account too). I
> have no idea why you'd even consider that.
If you or any other developer is against someone receiving git write access
you only need to object to the patch adding him to the MAINTAINERS file.
Thats one of the reasons why there is a MAINTAINERs file.
It would be ideal IMO if for each part of teh codebase at least one person
with write access cares/"Maintains" it. Is there someone who already has
write access who wants to take care of opensrt.c ?
(it seemed there is little interrest from teh lack of replies in the thread so
Also i belive there already is a developer from nablet who is in the
MAINTAINERs file and has write access.
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
In a rich man's house there is no place to spit but his face.
-- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 181 bytes
Desc: not available
More information about the ffmpeg-devel