[FFmpeg-devel] [PATCH 2/2] libavfilter/vf_fps: Rewrite using activate callback

Calvin Walton calvin.walton at kepstin.ca
Mon Feb 19 22:58:17 EET 2018

Hi Nicolas,

On Sun, 2018-02-18 at 19:01 +0100, Nicolas George wrote:
> Thanks for the patch. It was something I had in my TODO list for a
> long
> time. The code looks very good. Here are a few comments below. Of
> course
> open to discussion.

Thanks for the review. I'm going to spend some time going over it now.
I've noticed in my testing that I completely forgot to hook up the
'start_time' option, so expect a patch respin fixing that and
addressing your comments as well.

(I'll look at writing some tests for the start_time option too.)

Calvin Walton <calvin.walton at kepstin.ca>

More information about the ffmpeg-devel mailing list