[FFmpeg-devel] Pull requests

Lou Logan lou at lrcd.com
Tue Feb 27 00:16:49 EET 2018

On Mon, Feb 26, 2018, at 12:39 PM, Bjorn Roche wrote:
> I have a patch I'd like to submit -- can I submit a PR on GitHub, or no?

The main problem with github and such is that all development discussions and reviews occur at one location: the ffmpeg-devel mailing list. PRs are therefore out of our workflow. The other problem is that the PRs are often nonsense or accidental so the signal-to-noise ratio isn't great. So PRs are forgotten or ignored. Admittedly it's not an ideal situation, but we are not the only ones who don't accept PRs (Linux kernel for example).

However, we do accept attached patches made by "git format-patch", so that could present a workaround. If your usage of github is non-negotiable I believe you can do your github stuff, view the commit on the github site, append the ".patch" extension to the end of the URL to get the raw patch, and attach the patch to a message to this mailing list. I'm not a github user, so this suggestion may be incorrect, but I believe that should work as long as your mail client doesn't mangle the patch.

More information about the ffmpeg-devel mailing list