[FFmpeg-devel] [PATCH] compat: remove in-tree NVidia headers

Hendrik Leppkes h.leppkes at gmail.com
Tue Feb 27 13:01:48 EET 2018


On Tue, Feb 27, 2018 at 11:59 AM, wm4 <nfxjfg at googlemail.com> wrote:
> On Tue, 27 Feb 2018 11:49:25 +0100
> Hendrik Leppkes <h.leppkes at gmail.com> wrote:
>
>> On Tue, Feb 27, 2018 at 11:45 AM, wm4 <nfxjfg at googlemail.com> wrote:
>> > On Mon, 26 Feb 2018 22:15:04 +0100 (CET)
>> > Marton Balint <cus at passwd.hu> wrote:
>> >
>> >> On Mon, 26 Feb 2018, Timo Rothenpieler wrote:
>> >>
>> >> > The reason I haven't pushed this yet is because it breaks the build on
>> >> > MSVC, and I haven't gotten around to figuring out pkg-config for it.
>> >>
>> >> Right. I picked this up because I thought it would be nice if we could go
>> >> through with it before the upcoming release. I am not sure I can help with
>> >> MSVC though because I don't have an MSVC build enviroment at the moment.
>> >
>> > We could just leave it to whoever wants to use MSVC to build this.
>> > Somewhat justified IMHO, because it's an obscure hard to test
>> > configuration (using MSVC _and_ some hw/vendor specific driver).
>>
>> Knowingly breaking working configurations is not acceptable.
>
> Just make it unsupported via configure.

And thats not breaking something that works today, how?

Something works today, you want to refactor it, you get to keep it
working. Its a simple rule.

- Hendrik


More information about the ffmpeg-devel mailing list