[FFmpeg-devel] [PATCH] Revert "Remove battleforthenet widget"

wm4 nfxjfg at googlemail.com
Wed Feb 28 20:39:23 EET 2018


On Wed, 28 Feb 2018 18:17:42 +0100
Michael Niedermayer <michael at niedermayer.cc> wrote:

> The widget has new content.
> 
> This reverts commit 9275cd54eddb83faf5bd40ffaccb5717de8b798d.
> ---
>  src/template_head2 | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
> 
> diff --git a/src/template_head2 b/src/template_head2
> index a0b11ab..71daf07 100644
> --- a/src/template_head2
> +++ b/src/template_head2
> @@ -3,6 +3,29 @@
>        <script src="js/html5shiv.min.js"></script>
>        <script src="js/respond.min.js"></script>
>      <![endif]-->
> +    <script type="text/javascript">
> +    var _bftn_options = {
> +        /*
> +        * Specify view cookie expiration. After initial view, modal will not be
> +        * displayed to a user again until after this cookie expires. Defaults to one
> +        * day.
> +        */
> +        viewCookieExpires: 60, // @type {number}
> +
> +        /*
> +        * Specify action cookie expiration. After initiating a call or clicking a
> +        * donate link, modal will not be displayed to a user again until after this
> +        * cookie expires. Defaults to one week.
> +        */
> +        actionCookieExpires: 60, // @type {number}
> +
> +        /*
> +        * Prevents the widget iframe from loading Google Analytics. Defaults to false.
> +        */
> +        disableGoogleAnalytics: true, // @type {boolean}
> +    };
> +    </script>
> +    <script src="https://widget.battleforthenet.com/widget.js" async></script>
>  
>      <link href="main.rss" rel="alternate" type="application/rss+xml" title="ffmpeg.org" />
>      <link rel="shortcut icon" href="favicon.ico" />

1. Including active content from a 3rd party site we can't control is
   not a good idea.
2. Last time, it was in a broken state after the event (still showed
   up, and showed negative time or so).
3. There's no reason to bother people outside the US with US politics.
4. Is there a new campaign or what does the widget even do? I see
   something about Feb 27, which was yesterday.


More information about the ffmpeg-devel mailing list