[FFmpeg-devel] [FFmpeg-cvslog] w32pthreads: always use Vista+ API, drop XP support

[wm4]

On Tue, 2 Jan 2018 03:55:18 +0100
Michael Niedermayer <michael at niedermayer.cc> wrote:

> On Tue, Dec 26, 2017 at 01:50:08AM +0000, wm4 wrote:
> > ffmpeg | branch: master | wm4 <nfxjfg at googlemail.com> | Thu Dec 21 20:23:14 2017 +0100| [9b121dfc32810250938021952aab4172a988cb56] | committer: wm4
> > 
> > w32pthreads: always use Vista+ API, drop XP support
> > 
> > This removes the XP compatibility code, and switches entirely to SWR
> > locks, which are available starting at Windows Vista.
> > 
> > This removes CRITICAL_SECTION use, which allows us to add
> > PTHREAD_MUTEX_INITIALIZER, which will be useful later.
> > 
> > Windows XP is hereby not a supported build target anymore. It was
> > decided in a project vote that this is OK.
> >   
> > > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=9b121dfc32810250938021952aab4172a988cb56  
> > ---
> > 
> >  Changelog                  |   2 +
> >  compat/w32pthreads.h       | 266 ++-------------------------------------------
> >  configure                  |  13 ++-
> >  libavcodec/pthread_frame.c |   4 -
> >  libavcodec/pthread_slice.c |   4 -
> >  libavfilter/pthread.c      |   4 -
> >  libavutil/slicethread.c    |   4 -
> >  7 files changed, 19 insertions(+), 278 deletions(-)  
> 
> This breaks mingw32 / wine support on ubuntu 14.04
> the code simply crashes at runtime
> 
> [...]

wine usually doesn't implement the full win32 API, so it's a given that
some programs fail.

InitializeConditionVariable in particular can not fail according to MSDN.