[FFmpeg-devel] [PATCH] lavc/qsvdec: hw device should be set

[Li, Zhong]

> From: ffmpeg-devel [mailto:ffmpeg-devel-bounces at ffmpeg.org] On Behalf
> Of Mark Thompson
> Sent: Tuesday, January 2, 2018 8:32 PM
> To: ffmpeg-devel at ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsvdec: hw device should be set
> 
> On 02/01/18 09:15, Li, Zhong wrote:
> >> From: ffmpeg-devel [mailto:ffmpeg-devel-bounces at ffmpeg.org] On
> Behalf
> >> Of Mark Thompson
> >> Sent: Tuesday, January 2, 2018 7:36 AM
> >> To: ffmpeg-devel at ffmpeg.org
> >> Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsvdec: hw device should be
> >> set
> >>
> >> On 29/12/17 07:06, Zhong Li wrote:
> >>> Add the flag "AV_CODEC_HW_CONFIG_METHOD_HW_DEVICE_CTX" to
> >> indicate
> >>> AVCodecContext.hw_device_ctx should be set before calling
> >>> avcodec_open2() for qsv decoding.
> >>> It is consistent with examples/qsvdec.c.
> >>>
> >>> It also can make function "hw_device_match_by_codec()" can find qsv
> >>> device successfully.
> >>>
> >>> Signed-off-by: Zhong Li <zhong.li at intel.com>
> >>> ---
> >>>  libavcodec/qsvdec.c | 3 ++-
> >>>  1 file changed, 2 insertions(+), 1 deletion(-)
> >>>
> >>> diff --git a/libavcodec/qsvdec.c b/libavcodec/qsvdec.c index
> >>> 55fe59b..ff1dcf1 100644
> >>> --- a/libavcodec/qsvdec.c
> >>> +++ b/libavcodec/qsvdec.c
> >>> @@ -45,7 +45,8 @@ const AVCodecHWConfigInternal
> >> *ff_qsv_hw_configs[] = {
> >>>      &(const AVCodecHWConfigInternal) {
> >>>          .public = {
> >>>              .pix_fmt     = AV_PIX_FMT_QSV,
> >>> -            .methods     =
> >> AV_CODEC_HW_CONFIG_METHOD_HW_FRAMES_CTX |
> >>> +            .methods     =
> >> AV_CODEC_HW_CONFIG_METHOD_HW_DEVICE_CTX |
> >>> +
> >> AV_CODEC_HW_CONFIG_METHOD_HW_FRAMES_CTX |
> >>>
> >> AV_CODEC_HW_CONFIG_METHOD_AD_HOC,
> >>>              .device_type = AV_HWDEVICE_TYPE_QSV,
> >>>          },
> >>>
> >>
> >> Did you omit a patch implementing this?  The change here is only to
> >> the metadata, and it's not currently implemented.
> >
> > Sorry maybe I omitted it, could you specify which patch?
> 
> You sent one patch, which is just adding the HW_DEVICE_CTX method flag
> for AV_PIX_FMT_QSV output.  The feature itself is not implemented in
> current lavc, however, so applying it as-is would be wrong.  Hence I'm
> wondering if you forgot to send a patch before it which implements the
> feature first?

Got it. I will update it as a patch set. Thanks for your remind.