[FFmpeg-devel] [PATCH 5/5] aptx: add raw muxer and demuxer for aptX HD

[Aurelien Jacobs]

On Sun, Jan 07, 2018 at 12:53:27AM +0100, Michael Niedermayer wrote:
> On Sat, Jan 06, 2018 at 05:48:08PM +0100, Aurelien Jacobs wrote:
> > ---
> >  Changelog                |  2 +-
> >  libavformat/Makefile     |  2 ++
> >  libavformat/allformats.c |  1 +
> >  libavformat/aptxdec.c    | 51 ++++++++++++++++++++++++++++++++++++++++++++----
> >  libavformat/rawenc.c     | 13 ++++++++++++
> >  5 files changed, 64 insertions(+), 5 deletions(-)
> [...]
> > @@ -66,6 +94,7 @@ static const AVClass aptx_demuxer_class = {
> >      .version    = LIBAVUTIL_VERSION_INT,
> >  };
> >  
> > +#if CONFIG_APTX_MUXER
> >  AVInputFormat ff_aptx_demuxer = {
> >      .name           = "aptx",
> >      .long_name      = NULL_IF_CONFIG_SMALL("raw aptX"),
> > @@ -76,3 +105,17 @@ AVInputFormat ff_aptx_demuxer = {
> >      .flags          = AVFMT_GENERIC_INDEX,
> 
> >      .priv_class     = &aptx_demuxer_class,
> [...]
> > +    .priv_class     = &aptx_demuxer_class,
> 
> this cause the code (for example fate) to infinite loop

Oh, indeed, it seems 2 demuxers can't share the same priv_class.
Here is an updated patch.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-aptx-add-raw-muxer-and-demuxer-for-aptX-HD.patch
Type: text/x-diff
Size: 6273 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180107/ab86a018/attachment.patch>