[FFmpeg-devel] [PATCHv3] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

[Michael Niedermayer]

On Sun, Jan 28, 2018 at 03:36:47PM +0000, Kieran Kunhya wrote:
> Patch updated to fix threading related crashes, thanks to Paul Mahol for
> assistance.

> Also fix segfaults on cut files by disabling unchecked bitstream reading.

if unchecked bitstream reading segfaults then you are probably missing
error checks.
mpeg4 does not allow arbitrary long runs of zeros, and there are zeros in the
padding at the end of the bitstream so this should trigger an error as a
long all zero code would never be valid

Looking at the code i see that in teh DPCM branch check_marker() failure is ignored.
That could lead to a overread and segfault

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

What does censorship reveal? It reveals fear. -- Julian Assange
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180128/dfaf0805/attachment.sig>