[FFmpeg-devel] [PATCH v2][GSOC] avfilter: added colorconstancy

[Gyan Doshi]

On 15-07-2018 07:50 AM, Mina wrote:

> +A variation color constancy that estimates scene illumination via grey edge algorithm
> +and corrects the scene colors accordingly.

"A variation color constancy filter which estimates ..."

Maybe add a link to the algo paper in the next line:

"Grey Edge algorithm: http://..."


 > +The order of diffrentation to be applied on the scene. Must be 
chosen in the range

diffrentation -> differentiation

 > +chosen in the range [0,1024.0] and default value = 1. Sigma can't be 
set to 0
 > +if @var{difford} is greater than 1.

but for set_gauss, you say

 > Sigma can be zero only at difford = 0

and test during config

 > av_assert0(sigma || !s->difford);

Please correct the docs. Also prefer that you log an informational error 
and return AVERROR(EINVAL) instead of an assert.


Thanks,
Gyan