[FFmpeg-devel] [PATCH] avcodec/mips: [loongson] optimize vp8 decoding in vp8dsp.

[Carl Eugen Hoyos]

2018-06-14 9:36 GMT+02:00, Shiyou Yin <yinshiyou-hf at loongson.cn>:
> From: gxw <guxiwei-hf at loongson.cn>
>
> Optimize vp8 decoding with mmi in function:
> 1. ff_vp8_h_loop_filter8uv_mmi.
> 2. ff_vp8_v_loop_filter8uv_mmi.
> 3. ff_vp8_h_loop_filter16_mmi.
> 4. ff_vp8_v_loop_filter16_mmi.

Please add some numbers about the speedup, overall and / or
function-wise.

> +#if 0
>      int i;
>
>      for (i = 0; i < 8; i++)
> @@ -630,6 +876,73 @@ static av_always_inline void
> vp8_v_loop_filter8_mmi(uint8_t *dst,
>              else
>                  filter_mbedge(dst + i * 1, stride);
>          }
> +#else

I suspect you maintain this code but unless there is a very
good reason, you should remove dead / replaced code, not
comment it out.

Thank you, Carl Eugen