[FFmpeg-devel] [PATCH] lavfi/colorspace: Add namespace prefix to global functions

[Mark Thompson]

On 26/06/18 01:50, Song, Ruiling wrote:
>> -----Original Message-----
>> From: ffmpeg-devel [mailto:ffmpeg-devel-bounces at ffmpeg.org] On Behalf Of
>> Mark Thompson
>> Sent: Tuesday, June 26, 2018 5:02 AM
>> To: ffmpeg-devel at ffmpeg.org
>> Subject: [FFmpeg-devel] [PATCH] lavfi/colorspace: Add namespace prefix to
>> global functions
>>
>> ---
>> On 25/06/18 02:34, Song, Ruiling wrote:
>>>> -----Original Message-----
>>>> From: ffmpeg-devel [mailto:ffmpeg-devel-bounces at ffmpeg.org] On Behalf
>> Of
>>>> Mark Thompson
>>>> Sent: Monday, June 25, 2018 2:26 AM
>>>> To: ffmpeg-devel at ffmpeg.org
>>>> Subject: [FFmpeg-devel] [PATCH 1/5] lavfi/colorspace: Add namespace prefix
>> to
>>>> global functions
>>>>
>>>> ---
>>>>  libavfilter/colorspace.c        | 13 +++++++------
>>>>  libavfilter/colorspace.h        | 10 ++++++----
>>>>  libavfilter/vf_colorspace.c     | 22 +++++++++++-----------
>>>>  libavfilter/vf_tonemap_opencl.c |  8 ++++----
>>>>  4 files changed, 28 insertions(+), 25 deletions(-)
>>>>
>>>> ...
>>>> --- a/libavfilter/colorspace.h
>>>> +++ b/libavfilter/colorspace.h
>>>> @@ -34,8 +34,10 @@ struct WhitepointCoefficients {
>>>>      double xw, yw;
>>>>  };
>>>>
>>>> -void invert_matrix3x3(const double in[3][3], double out[3][3]);
>>>> -void mul3x3(double dst[3][3], const double src1[3][3], const double
>> src2[3][3]);
>>>> -void fill_rgb2xyz_table(const struct PrimaryCoefficients *coeffs,
>>>> -                        const struct WhitepointCoefficients *wp, double rgb2xyz[3][3]);
>>>> +void ff_invert_matrix3x3(const double in[3][3], double out[3][3]);
>>>> +void ff_mul3x3(double dst[3][3],
>>>> +               const double src1[3][3], const double src2[3][3]);
>>>> +void ff_fill_rgb2xyz_table(const struct PrimaryCoefficients *coeffs,
>>>> +                           const struct WhitepointCoefficients *wp,
>>>> +                           double rgb2xyz[3][3]);
>>> I am basically ok with the patch. But I am not sure whether below function
>> names would be more applicable as now they are under 'ff_' prefix.
>>> ff_matrix_inverse_3x3()
>>> ff_matrix_mul_3x3()
>>
>> Yeah, those names would probably be better.
>>
>> How about this?
> This version LGTM!

Applied.

Thanks,

- Mark