[FFmpeg-devel] [PATCH 4/8] avformat/movenc: Check that frame_types other than EAC3_FRAME_TYPE_INDEPENDENT have a supported substream id

[Michael Niedermayer]

On Wed, Jun 27, 2018 at 08:11:17PM +0200, Michael Niedermayer wrote:
> Fixes: out of array access
> Fixes: ffmpeg_bof_1.avi
> 
> Found-by: Thuan Pham, Marcel Böhme, Andrew Santosa and Alexandru Razvan Caciulescu with AFLSmart
> Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> ---
>  libavformat/movenc.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/libavformat/movenc.c b/libavformat/movenc.c
> index e2c5613f98..00567db586 100644
> --- a/libavformat/movenc.c
> +++ b/libavformat/movenc.c
> @@ -437,6 +437,12 @@ static int handle_eac3(MOVMuxContext *mov, AVPacket *pkt, MOVTrack *track)
>                  info->ec3_done = 1;
>                  goto concatenate;
>              }
> +        } else {
> +            if (hdr->substreamid != 0) {
> +                avpriv_request_sample(track->par, "Multiple dependent substreams");

Changed the wording to be more precisse and also fixed the copy and paste bug
in the context

will apply

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The worst form of inequality is to try to make unequal things equal.
-- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180628/7894bad7/attachment.sig>