[FFmpeg-devel] [PATCH] libavfilter: Add OpenCL convolution filter v0.1

[Carl Eugen Hoyos]

2018-03-14 10:43 GMT+01:00, Danil Iashchenko <danyaschenko at gmail.com>:

> About sscanf. I had (!err_code) condition, because I would never
> get empty line as option (if not specified, I always have default
> matrix), but changed to (err_code != 1) due to read-ability.

Was this requested?
I ask because several developers believe the opposite is true...

[...]

> --- /dev/null
> +++ b/libavfilter/opencl/convolution.cl
> @@ -0,0 +1,46 @@
> +/*
> + * This file is part of FFmpeg.

Please add your name.

[...]

> +    for (i = 0; i < 4; i++) {
> +        p = ctx->matrix_str[i];
> +        while (ctx->matrix_size[i] < 49) {

> +            if (!(arg = av_strtok(p, " ", &saveptr)))

Please split this line.

And ask one of the mentors to add your name to the OpenCL project
on https://trac.ffmpeg.org/wiki/SponsoringPrograms/GSoC/2018 -
other potential students should know that you are interested in this
project and that you have (nearly) completed a qualification task.

Thank you, Carl Eugen