[FFmpeg-devel] [PATCH 1/2] fftools/cmdutils: add logflags option

Tobias Rapp t.rapp at noa-archive.com
Tue Mar 20 10:36:51 EET 2018


On 20.03.2018 02:44, Michael Niedermayer wrote:
> On Mon, Mar 19, 2018 at 09:31:44AM +0100, Tobias Rapp wrote:
>> On 14.03.2018 09:55, Tobias Rapp wrote:
>>> Allows to set the AV_LOG_PRINT_LEVEL and AV_LOG_SKIP_REPEATED flags
>>> using a distinct command-line option, similar to other flag options.
>>> Previously only the AV_LOG_SKIP_REPEATED flag was supported as a prefix
>>> to the "loglevel" option value.
>>>
>>> Signed-off-by: Tobias Rapp <t.rapp at noa-archive.com>
>>> ---
>>>   doc/fftools-common-opts.texi | 13 +++++++++++++
>>>   fftools/cmdutils.c           | 31 +++++++++++++++++++++++++++++++
>>>   fftools/cmdutils.h           |  6 ++++++
>>>   3 files changed, 50 insertions(+)
>>>
>>> [...]
>>
>> Any opinions? My motivation was adding support for AV_LOG_PRINT_LEVEL on the
>> CLI. Using the existing flags option string parsing functions seemed easier
>> and more consistent that extending the custom loglevel string parser.
> 
> this means the feature would require every user app to add similar code
> if one wants to support it.
> 
> it would be better if apps do not need changes for added options

Not sure I understand. Do you mean user apps that link to libav* 
libraries and want to mimic the command-line options of 
ffmpeg/ffprobe/ffplay? What alternative would you suggest for managing 
AV_LOG_PRINT_LEVEL via command-line options?

Regards,
Tobias



More information about the ffmpeg-devel mailing list