[FFmpeg-devel] [PATCH 0/1] re: Add Sega FILM muxer

misty at brew.sh misty at brew.sh
Sat Mar 24 05:00:52 EET 2018


From: Misty De Meo <mistydemeo at gmail.com>

> Just move allocation after all declarations.

OK, changed.

> Do you check that this condition is set in code?
>
> I mean, if user set codec for wrong case.

Oh, good point. I thought about this, and then realized that for mono audio,
there is no difference between planar and non-planar. If the muxer only accepts
planar then it'll work in both cases and there doesn't have to be a special
check. That also matches the behaviour of the demuxer, which marks streams as
planar regardless of channel layout.

> this is set but never used

Good catch - removed. Left over from an older version of the header generation.

Misty De Meo (1):
  Add Sega FILM muxer

 Changelog                 |   1 +
 libavformat/Makefile      |   1 +
 libavformat/allformats.c  |   1 +
 libavformat/segafilmenc.c | 377 ++++++++++++++++++++++++++++++++++++++++++++++
 4 files changed, 380 insertions(+)
 create mode 100644 libavformat/segafilmenc.c

-- 
2.16.2



More information about the ffmpeg-devel mailing list