[FFmpeg-devel] [PATCH 4/6] avdevice/decklink_dec: use av_packet_make_ref to ensure packets are ref counted
James Almer
jamrial at gmail.com
Sun Mar 25 07:03:37 EEST 2018
Partially reverts commit e91f0c4f8b, simplifying code.
Signed-off-by: James Almer <jamrial at gmail.com>
---
libavdevice/decklink_dec.cpp | 12 +++++-------
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/libavdevice/decklink_dec.cpp b/libavdevice/decklink_dec.cpp
index 28a748a28f..0ccf87f94f 100644
--- a/libavdevice/decklink_dec.cpp
+++ b/libavdevice/decklink_dec.cpp
@@ -464,24 +464,22 @@ static unsigned long long avpacket_queue_size(AVPacketQueue *q)
static int avpacket_queue_put(AVPacketQueue *q, AVPacket *pkt)
{
AVPacketList *pkt1;
- int ret;
// Drop Packet if queue size is > maximum queue size
if (avpacket_queue_size(q) > (uint64_t)q->max_q_size) {
av_log(q->avctx, AV_LOG_WARNING, "Decklink input buffer overrun!\n");
return -1;
}
+ /* ensure the packet is reference counted */
+ if (av_packet_make_ref(pkt) < 0) {
+ return -1;
+ }
pkt1 = (AVPacketList *)av_mallocz(sizeof(AVPacketList));
if (!pkt1) {
return -1;
}
- ret = av_packet_ref(&pkt1->pkt, pkt);
- av_packet_unref(pkt);
- if (ret < 0) {
- av_free(pkt1);
- return -1;
- }
+ av_packet_move_ref(&pkt1->pkt, pkt);
pkt1->next = NULL;
pthread_mutex_lock(&q->mutex);
--
2.16.2
More information about the ffmpeg-devel
mailing list