[FFmpeg-devel] [PATCH 12/24] avcodec/mjpegenc: add support for non-YUVJ formats
cus at passwd.hu
Wed May 2 21:04:05 EEST 2018
On Tue, 1 May 2018, Rostislav Pehlivanov wrote:
> On 1 May 2018 at 23:22, Paul B Mahol <onemda at gmail.com> wrote:
>> On 5/2/18, Michael Niedermayer <michael at niedermayer.cc> wrote:
>> > Hi
>> > On Tue, May 01, 2018 at 09:40:01PM +0200, Paul B Mahol wrote:
>> >> Signed-off-by: Paul B Mahol <onemda at gmail.com>
>> >> ---
>> >> libavcodec/mjpegenc.c | 5 ++++-
>> >> libavcodec/mpegvideo_enc.c | 3 +--
>> >> tests/lavf-regression.sh | 2 +-
>> >> 3 files changed, 6 insertions(+), 4 deletions(-)
>> > This doesnt work
>> It does work, if you want full range set full range as option.
>> Check visually colors.
>> This happens because rgb is still marked incorrectly as limited range,
>> so limited is picked instead.
> Shouldn't this be part of the patchset?
I thought that color_range only matters for YUV formats, for RGB it is
ignored. If it was decided to support limited RGB, then please update the
docs of AVCOL_RANGE_JPEG/MPEG. Otherwise the color_range of an RGB format
should not matter.
On the other hand, if we decide to support limited RGB, then maybe a new
member in color_range is better, this way we are able to specify more
easily that we support limited YUV and full range RGB. (like ffplay
More information about the ffmpeg-devel