[FFmpeg-devel] [PATCH]avocdec/nvenc: Reconfigure bitrate on the fly
timo at rothenpieler.org
Thu May 3 01:21:54 EEST 2018
> thanks for your feedback.
> I was not sure of whether to put the capability check with the others in
> nvenc_check_capabilities because if the cap is missing this would remove
> the encoder altogether:
> ex: ln. 453 : if ((ret = nvenc_check_capabilities(avctx)) < 0)
> goto fail3;
> I'll move it there then or if you think it's preferrable, I can move it
> to ff_nvenc_encode_init and store it.
> Which option do you prefer ? I'll resubmit and rebase once the other
> patch is committed.
Just add a new field to the struct NvencContext.
And there is no need to fail on this check, store its result and go on,
unless it's < 0, which indicates an actual error.
There's also no need to check for a changed bitrate outside of the call
to reconfig_encoder, when making the same check inside of it again.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 3994 bytes
Desc: S/MIME Cryptographic Signature
More information about the ffmpeg-devel