[FFmpeg-devel] [PATCH 1/4] cbs_h265: read/write HEVC PREFIX SEI

[Mark Thompson]

On 04/05/18 05:03, Xiang, Haihao wrote:
> On Thu, 2018-05-03 at 22:32 +0100, Mark Thompson wrote:
>> On 03/05/18 04:07, Haihao Xiang wrote:
>>> Similar to H264, cbs_h265_{read, write}_nal_unit() can handle HEVC
>>> prefix SEI NAL units. Currently mastering display colour volume SEI
>>> message is added only, we may add more SEI message if needed later
>>>
>>> v2: Fix coding style and rebase the code
>>>
>>> Signed-off-by: Haihao Xiang <haihao.xiang at intel.com>
>>> ---
>>>  libavcodec/cbs_h2645.c                |  45 ++++++++++
>>>  libavcodec/cbs_h265.h                 |  36 ++++++++
>>>  libavcodec/cbs_h265_syntax_template.c | 157
>>> ++++++++++++++++++++++++++++++++++
>>>  3 files changed, 238 insertions(+)
>>
>> Please run this through trace_headers with a suitable input and make sure it
>> works and that the output is correct.  (It currently hits some asserts.)
>>
>> ./ffmpeg_g -i input-with-hdr-metadata.mkv -c:v copy -bsf:v trace_headers -f
>> null -
>>
> 
> Sorry, I didn't run the above command to make sure reading SEI message works. I
> have root-caused it and will update the patch. 
> 
> BTW reading H.264 SEI message also hits this assert if the SEI message is
> handled in the default path in cbs_h264_read_sei_payload(). I will fix it too.

Yeah.  (And also shows that fate doesn't actually cover the SEI cases at all.  The data_length element is broken too.  I've made an artificial stream with a lot of suitable SEI types in for this, I'll send it soon so this is actually tested.)

Thanks,

- Mark