[FFmpeg-devel] avdevice/sdl output : fix window_size and add new option (WIP)

Martin Vignali martin.vignali at gmail.com
Tue May 8 12:59:02 EEST 2018


2018-04-20 22:24 GMT+02:00 Moritz Barsnick <barsnick at gmx.net>:

> On Sun, Apr 08, 2018 at 17:28:24 +0200, Martin Vignali wrote:
>
> > - 001 : Fix -window_size option
> > Before this patch, window_size is always set to the source size
> > In other word, -window_size option have no effect.
>
> Makes sense, since the option was already there.
>
> > - 002 : Add option to set the position of the window
> > the default behaviour doesn't change (set the position to undefined)
>
> A -window_size syntax such as 1024x768+100+100 would seem intuitive to
> me (old Unix/X11 user), but perhaps that's just me, and I guess
> AV_OPT_TYPE_IMAGE_SIZE doesn't support that.
>
> > Comments Welcome
>
> -window_size: works for me
> -window_enable_quit 0: works for me
> -window_pos_x/-window_pos_y: doesn't work for me, but I can only test
>  remote X11 (Xwayland) via ssh
>
>
>
Thanks for comments and testing.
Dropped the window_pos patch.

New patch in attach :
- 001 : Fix -window_size option --> Unchanged patch
- 002 : Add option to disable quit action : Add doc

Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-avdevice-sdl2output-fix-setting-window_size.patch
Type: application/octet-stream
Size: 1430 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180508/f8acc995/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-avdevice-sdl2-add-option-to-define-if-the-window-qui.patch
Type: application/octet-stream
Size: 2217 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180508/f8acc995/attachment-0001.obj>


More information about the ffmpeg-devel mailing list