[FFmpeg-devel] [PATCH 03/13] avformat/mxfenc: Add Product Version, Toolkit version and Platform

Tomas Härdin tjoppen at acc.umu.se
Tue May 8 13:28:48 EEST 2018


mån 2018-05-07 klockan 12:38 +0200 skrev Michael Niedermayer:
> > Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
>  static void mxf_write_identification(AVFormatContext *s)
>  {
>      MXFContext *mxf = s->priv_data;
> @@ -790,7 +809,7 @@ static void mxf_write_identification(AVFormatContext *s)
>  
>      version = s->flags & AVFMT_FLAG_BITEXACT ?
>          "0.0.0" : AV_STRINGIFY(LIBAVFORMAT_VERSION);
> -    length = 72 + mxf_utf16_local_tag_length(company) +
> +    length = 100 +mxf_utf16_local_tag_length(company) +

I have mixed feelings about this style of computation. But not enough
to hold the patch up, which looks OK

/Tomas





More information about the ffmpeg-devel mailing list