[FFmpeg-devel] [PATCH 02/13] avformat/mxfenc: Bump minor versions for S377-1-2009

Michael Niedermayer michael at niedermayer.cc
Tue May 8 18:48:47 EEST 2018


On Mon, May 07, 2018 at 06:27:37PM +0200, Carl Eugen Hoyos wrote:
> 2018-05-07 12:38 GMT+02:00, Michael Niedermayer <michael at niedermayer.cc>:
> 
> > diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c
> > index c0db10b3c2..00dfce977b 100644
> > --- a/libavformat/mxfenc.c
> > +++ b/libavformat/mxfenc.c
> > @@ -691,7 +691,7 @@ static void mxf_write_preface(AVFormatContext *s)
> >
> >      // write version
> >      mxf_write_local_tag(pb, 2, 0x3B05);
> > -    avio_wb16(pb, 258); // v1.2
> > +    avio_wb16(pb, 259); // v1.2
> 
> I find it surprising that the comment doesn't change here.

will fix and apply

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Rewriting code that is poorly written but fully understood is good.
Rewriting code that one doesnt understand is a sign that one is less smart
then the original author, trying to rewrite it will not make it better.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180508/6f63ffe9/attachment.sig>


More information about the ffmpeg-devel mailing list