[FFmpeg-devel] [PATCH 10/13] avformat/mxfenc: Set color siting to 0 for D10-MXF

[Michael Niedermayer]

On Tue, May 08, 2018 at 07:41:33PM +0200, Michael Niedermayer wrote:
> On Tue, May 08, 2018 at 12:55:18PM +0200, Tomas Härdin wrote:
> > mån 2018-05-07 klockan 12:38 +0200 skrev Michael Niedermayer:
> > > > Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> > > ---
> > >  libavformat/mxfenc.c                          |   1 +
> > >  .../ref/fate/concat-demuxer-extended-lavf-mxf |   2 +-
> > >  .../fate/concat-demuxer-extended-lavf-mxf_d10 |   2 +-
> > >  .../ref/fate/concat-demuxer-simple1-lavf-mxf  | 242 +++++++++---------
> > >  .../fate/concat-demuxer-simple1-lavf-mxf_d10  | 140 +++++-----
> > >  tests/ref/seek/lavf-mxf                       |  44 ++--
> > >  tests/ref/seek/lavf-mxf_d10                   |  54 ++--
> > >  tests/ref/seek/lavf-mxf_dv25                  |  54 ++--
> > >  tests/ref/seek/lavf-mxf_dvcpro50              |  54 ++--
> > >  tests/ref/seek/lavf-mxf_opatom                |  54 ++--
> > >  tests/ref/seek/lavf-mxf_opatom_audio          |  54 ++--
> > >  11 files changed, 351 insertions(+), 350 deletions(-)
> > > 
> > > diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c
> > > index f2be76cc86..adf5527534 100644
> > > --- a/libavformat/mxfenc.c
> > > +++ b/libavformat/mxfenc.c
> > > @@ -2361,6 +2361,7 @@ static int mxf_write_header(AVFormatContext *s)
> > >                  mxf->edit_unit_byte_count += klv_fill_size(mxf->edit_unit_byte_count);
> > >  
> > >                  sc->signal_standard = 1;
> > > +                sc->color_siting = 0;
> > >              }
> > 
> > Can't find anything in my documents that says anything about this. I
> > don't remember what D-10 is actually specified in...
> 
> SMPTE 386M (D-10) lists 4 as value to be used
> SMPTE 377-1-2009 says 
>     "The definitions of 00h (coSiting) and 04h (Rec 601) are equivalent. The value of 04h is deprecated. New
>      MXF encoders shall use the value of 00h instead."
> 
> I will add this to the commit message

will apply

[...]


-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Let us carefully observe those good qualities wherein our enemies excel us
and endeavor to excel them, by avoiding what is faulty, and imitating what
is excellent in them. -- Plutarch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180512/5bf57b90/attachment.sig>