[FFmpeg-devel] [PATCH] avutil/error: document av_err2str

Tobias Rapp t.rapp at noa-archive.com
Thu May 17 13:19:54 EEST 2018


On 17.05.2018 11:24, Zhao Zhili wrote:
> ---
>   libavutil/error.h | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/libavutil/error.h b/libavutil/error.h
> index 71df4da..b357bfa 100644
> --- a/libavutil/error.h
> +++ b/libavutil/error.h
> @@ -115,6 +115,9 @@ static inline char *av_make_error_string(char *errbuf, size_t errbuf_size, int e
>   /**
>    * Convenience macro, the return value should be used only directly in
>    * function arguments but never stand-alone.
> + *
> + * @warning The macro uses compound literal which was introduced in C99. It may
> + *          not work in C++.
>    */
>   #define av_err2str(errnum) \
>       av_make_error_string((char[AV_ERROR_MAX_STRING_SIZE]){0}, AV_ERROR_MAX_STRING_SIZE, errnum)
> 

If not using the macro is enough to silence affected C++ compilers, I 
prefer this patch over the other one that hides the macro with ifdefs.

Regards,
Tobias



More information about the ffmpeg-devel mailing list