[FFmpeg-devel] [PATCH] libvpxenc: extend auto-alt-ref range

[James Almer]

On 11/3/2018 6:04 PM, James Zern wrote:
> On Sat, Nov 3, 2018 at 2:02 PM James Zern <jzern at google.com> wrote:
>> [...]
>>  #define COMMON_OPTIONS \
>>      { "auto-alt-ref",    "Enable use of alternate reference " \
>> -                         "frames (2-pass only)",                   OFFSET(auto_alt_ref),    AV_OPT_TYPE_INT, {.i64 = -1},      -1,      2,       VE}, \
>> +                         "frames (2-pass only)",                   OFFSET(auto_alt_ref),    AV_OPT_TYPE_INT, {.i64 = -1},      -1,      6,       VE}, \
> 
> This was extended earlier [1], but probably should have been made
> codec specific. I can do that, but we might want to keep the 0-2 range
> for vp8 now for compatibility. Any preferences?

What happens when you use the higher values while encoding VP8? Does it
error out or silently clips it to 1 internally?

If it errors out then yes, move it out of COMMON_OPTIONS and into each
encoder AVOption array.

> 
> [1] 41da4f8cb3 lavc/libvpxenc: fix -auto-alt-ref option type
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>