[FFmpeg-devel] [PATCH v2 1/7] lavc/qsvenc: enable ICQ and ICQ_LA on Linux

[Mark Thompson]

On 05/11/18 12:15, Zhong Li wrote:
> ICQ/ICQ_LA are enabled with MSDK V1.28
> 
> One example of ICQ_LA:
> ffmpeg -hwaccel qsv -c:v h264_qsv -i in.mp4 -c:v h264_qsv -global_quality 25 -look_ahead 1 out.mp4
> 
> Signed-off-by: Zhong Li <zhong.li at intel.com>
> ---
> ICQ mode will fail with some cases: https://github.com/Intel-Media-SDK/MediaSDK/issues/863. Don't merge this patch before it resolved.
> 
>  libavcodec/qsvenc.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavcodec/qsvenc.h b/libavcodec/qsvenc.h
> index 50cc426..055b4a6 100644
> --- a/libavcodec/qsvenc.h
> +++ b/libavcodec/qsvenc.h
> @@ -53,7 +53,7 @@
>  #define QSV_HAVE_MF     0
>  #else
>  #define QSV_HAVE_AVBR   0
> -#define QSV_HAVE_ICQ    0
> +#define QSV_HAVE_ICQ    QSV_VERSION_ATLEAST(1, 28)
>  #define QSV_HAVE_VCM    0
>  #define QSV_HAVE_QVBR   0
>  #define QSV_HAVE_MF     QSV_VERSION_ATLEAST(1, 25)
> 

LGTM once the issues with the driver are resolved.

(I guess this is another case in favour of querying the actual capabilities at runtime, though.)

Thanks,

- Mark