[FFmpeg-devel] [PATCH v2] lavf/isom: add Dolby Vision sample entry codes for HEVC and H.264

[Jan Ekström]

On Thu, Nov 8, 2018, 03:39 Carl Eugen Hoyos <ceffmpeg at gmail.com wrote:

> 2018-11-08 0:11 GMT+01:00, Jan Ekström <jeebjp at gmail.com>:
>
> > +    { AV_CODEC_ID_HEVC, MKTAG('d', 'v', 'h', '1') }, /* HEVC-based Dolby
> > Vision derived from hvc1 */
>
> As said before, this breaks real-world files, the patch is therefore not
> ok.
> (And as said before, the authority hasn't done their homework.)
>
> Carl Eugen
>

I think the authority really doesn't look further than "was this identifier
registered already?", which to be fair is not incorrect since you csn
consider everything outside mpeg-4 ra's lists unofficial/nonstandard.

Now, that said, sure. If the stuff got any real usage and you - I think -
have already handled dvh1 in some other point of code if I recall
correctly, then let's leave that thing at that.

Then regarding the rest. Do I understand correctly that you do not trust
dolby's specification and/or mpeg-4 ra and would only like identifiers be
added that have been seen in the wild?

Best regards,
Jan

>