[FFmpeg-devel] [PATCH] Optimize libavformat/metadata.c

[Hendrik Leppkes]

On Thu, Nov 15, 2018 at 10:27 AM Shlomi Fish <shlomif at shlomifish.org> wrote:
>
> Hi Marton,
>
> On Wed, 7 Nov 2018 10:29:31 +0100 (CET)
> Marton Balint <cus at passwd.hu> wrote:
>
> > On Wed, 7 Nov 2018, Shlomi Fish wrote:
> >
> > > On Wed, 4 Jul 2018 23:10:46 +0300
> > > Shlomi Fish <shlomif at shlomifish.org> wrote:
> > >
> > > Ping/bump! Can this patch be reviewed already?
> >
> > Does your patch has any measureable speed difference for some streams? It
> > seems like a very micro optimialization, because ff_metadata_conv bails
> > out early as well.
> >
>
> First of all note that I recall it being the case for several function calls
> in succession there. Secondly, I didn't measure it, but see what I wrote at:
>
> https://en.wikibooks.org/wiki/Optimizing_Code_for_Speed/Factor_Optimizations#Are_%22Small%22_Optimizations_Desirable?
>
> non-inline function calls can be quite slow.
>

Theoretical optimizations are all nice and well, but numbers are the
only reality in the world. :)

- Hendrik