[FFmpeg-devel] [PATCH] cbs: Add function to make content of a unit writable
Carl Eugen Hoyos
ceffmpeg at gmail.com
Sun Nov 25 23:54:52 EET 2018
2018-11-25 22:44 GMT+01:00, Andreas Rheinhardt
<andreas.rheinhardt at googlemail.com>:
> Carl Eugen Hoyos:
>> 2018-11-25 22:05 GMT+01:00, Andreas Rheinhardt
>> <andreas.rheinhardt at googlemail.com>:
>>> + .make_writable = NULL,
>> Why do you think these are needed?
> It's not needed. If left out, .make_writable will be implicitly initialized
> to a NULL pointer because the various ff_cbs_type_xyz all have static
> storage duration. But I nevertheless thought that it is nicer to make the
> initialization explicit, because then you actually see all the members of
> each CodedBitstreamType.
Please leave it out like in hundreds of existing cases.
More information about the ffmpeg-devel