[FFmpeg-devel] [PATCH] avformat/movenc : Don't write sidx for empty urls

Jeyapal, Karthick kjeyapal at akamai.com
Wed Nov 28 18:17:16 EET 2018


>´╗┐On 11/28/18, 8:19 PM, "Moritz Barsnick" <barsnick at gmx.net> wrote:
>
>On Wed, Nov 28, 2018 at 20:10:11 +0530, Karthick J wrote:
>> +            // If url is an empty string("") don't write sidx atom.
>> +            if (s->url[0] == '\0')
>> +                return res;
>
>Probably clearer if you return 0, as res hasn't been assigned anything
>up to this point, except its initial 0.
Makes sense. Sent PATCH v2 with this change.

Regards,
Karthick
>
>Moritz



More information about the ffmpeg-devel mailing list