[FFmpeg-devel] [PATCH 1/3] lavf/matroskadec: don't treat I/O errors as EOF

Marton Balint cus at passwd.hu
Wed Nov 28 21:19:04 EET 2018

On Wed, 28 Nov 2018, Rodger Combs wrote:

> pb->eof_reached is set on error, so we need to check pb->error,
> even after checking pb->eof_reached or avio_feof(pb), or else we
> can end up returning AVERROR_EOF instead of the actual error code.

Why eof_reached is set in the first place on error? Why does avio_feof() 
return nonzero if we are not at the end of file? That is strictly against 
its documentation.

Seems like a fine mess, let's think about how we will resolve this in a 
generic way.


More information about the ffmpeg-devel mailing list