[FFmpeg-devel] [PATCH] avcodec/libx264: remove FF_CODEC_CAP_INIT_THREADSAFE flag

[Derek Buitenhuis]

Hi,

On 21/10/2018 15:07, Henrik Gramner wrote:
> Fixed in x264-sandbox. All uses of plain strtok() will be removed from
> x264 in the next push.
> 
> I though all of the strtok() uses in x264 had already been converted
> to strtok_r() but apparently that wasn't the case. Sorry about that.

I'd like to point out that this patch or some variant may be required anyway.

libx264 only uses strtok_r or strtok_s if available on the platform.

See: https://git.videolan.org/?p=x264.git;a=blob;f=common/osdep.h;h=715ef8a00c01ad5a94de2b29a422429b9b1f0a53;hb=HEAD#l75

The real fix is to bundle a strtok_r implementation, or to just outright
require strtok_r/strtok_s. Sad, I know.

What platforms that x264 supports don't have it anyway?

- Derek