[FFmpeg-devel] [PATCH] doc/fate.texi: Mention that samples should be uploaded before pushing dependant commits
Michael Niedermayer
michael at niedermayer.cc
Wed Oct 31 02:41:34 EET 2018
On Wed, Oct 24, 2018 at 10:34:39AM +0530, Gyan wrote:
> On Wed, Oct 24, 2018 at 3:09 AM Michael Niedermayer <michael at niedermayer.cc>
> wrote:
>
> > Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> > ---
> > doc/fate.texi | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/doc/fate.texi b/doc/fate.texi
> > index a352994230..9ca77f7772 100644
> > --- a/doc/fate.texi
> > +++ b/doc/fate.texi
> > @@ -155,6 +155,8 @@ space on each client, network bandwidth and so on
> > benefit from smaller test case
> > Also keep in mind older checkouts use existing sample files, that means in
> > practice generally do not replace, remove or overwrite files as it likely
> > would
> > break older checkouts or releases.
> > +Also all needed samples for a commit should be uploaded before the commit
> > is
> > +pushed. Ideally 24h before.
> >
>
> Nit: merge the 2nd sentence into the first.
can you suggest a exact wording for that ?
The sentance seems already a bit long to me and describing a slightly
different area of potential issues
>
> Also, dependant -> dependent.
locally fixed
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
If you fake or manipulate statistics in a paper in physics you will never
get a job again.
If you fake or manipulate statistics in a paper in medicin you will get
a job for life at the pharma industry.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20181031/2d5bae21/attachment.sig>
More information about the ffmpeg-devel
mailing list