[FFmpeg-devel] [PATCH] prompeg_write() must report data all was written

Michael Niedermayer michael at niedermayer.cc
Tue Apr 2 00:20:08 EEST 2019

On Sun, Mar 31, 2019 at 02:32:34AM +0100, David Holroyd wrote:
> Previously, prompeg_write() would only report to caller that bytes we
> written when a FEC packet was actually created.  Not all RTP packets are
> expected to generate a FEC packet however, so this behavior was causing
> avio to retry writing the RTP packet, eventually forcing the FEC state
> machine to send a FEC packet erroneously (and so breaking out of the
> retry loop).
> This was resulting in incorrect FEC data being generated, and far too
> many FEC packets to be sent (~100% FEC overhead).
> ---
>  libavformat/prompeg.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)

this patch doesnt seem to apply automatically with git am

also no fate test changes, which indicates that this code is not tested.
I think it would be rather useful if there was a test that covers this,
otherwise any future change to thsís code could break it with the person


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Frequently ignored answer#1 FFmpeg bugs should be sent to our bugtracker. User
questions about the command line tools should be sent to the ffmpeg-user ML.
And questions about how to use libav* should be sent to the libav-user ML.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190401/5ebbfc6a/attachment.sig>

More information about the ffmpeg-devel mailing list