[FFmpeg-devel] [RFC 6/6] Add and use private linux headers for V4L2 request API ctrls

[Jonas Karlman]

On 2019-04-08 22:57, Carl Eugen Hoyos wrote:
> 2019-04-08 22:14 GMT+02:00, Jonas Karlman <jonas at kwiboo.se>:
>> From: Jernej Skrabec <jernej.skrabec at siol.net>
>>
>> ---
>>  libavcodec/h264-ctrls.h         | 192 +++++++++++++++++++++++++++++++
>>  libavcodec/hevc-ctrls.h         | 197 ++++++++++++++++++++++++++++++++
>>  libavcodec/mpeg2-ctrls.h        |  82 +++++++++++++
>>  libavcodec/v4l2_request_h264.c  |   5 +-
>>  libavcodec/v4l2_request_hevc.c  |   1 +
>>  libavcodec/v4l2_request_mpeg2.c |   1 +
>>  6 files changed, 476 insertions(+), 2 deletions(-)
>>  create mode 100644 libavcodec/h264-ctrls.h
>>  create mode 100644 libavcodec/hevc-ctrls.h
>>  create mode 100644 libavcodec/mpeg2-ctrls.h
>>
>> diff --git a/libavcodec/h264-ctrls.h b/libavcodec/h264-ctrls.h
>> new file mode 100644
>> index 0000000000..e2f83b3cdb
>> --- /dev/null
>> +++ b/libavcodec/h264-ctrls.h
>> @@ -0,0 +1,192 @@
>> +/* SPDX-License-Identifier: GPL-2.0 */
>> +/*
>> + * These are the H.264 state controls for use with stateless H.264
>> + * codec drivers.
> If this is the sixth patch, how does compilation of the first
> five patches work without it?

It currently does not, the non-public kernel headers containing format ctrls was added to patchset if someone wants to compile the code.
I forgot to add a DO-NOT-MERGE tag to this patch, the V4L2 format ctrls should come from kernel linux/videodev2.h uapi header once they are stable in a future kernel version.

Regards,
Jonas

>
> Carl Eugen
>