[FFmpeg-devel] avcodec/videotoolbox: add support for full range and 10bit pixel formats

[Carl Eugen Hoyos]

2019-04-09 19:45 GMT+02:00, Jan Ekström <jeebjp at gmail.com>:
> On Wed, Mar 27, 2019 at 11:32 PM der richter <der.richter at gmx.de> wrote:
>>
>> the second patch
>>
>
> Generally looks like a nice addition and apparently VideoToolbox seems
> to be properly supporting this sort of content (at least according to
> the results of https://github.com/mpv-player/mpv/issues/6546 ).
>
> The first part that I'm not really sure of is if:
>
>>
>> --- a/libavutil/hwcontext_videotoolbox.h
>> +++ b/libavutil/hwcontext_videotoolbox.h
>> @@ -49,6 +49,6 @@ enum AVPixelFormat
>> av_map_videotoolbox_format_to_pixfmt(uint32_t cv_fmt);
>>   * Convert an AVPixelFormat to a VideoToolbox (actually CoreVideo)
>> format.
>>   * Returns 0 if no known equivalent was found.
>>   */
>> -uint32_t av_map_videotoolbox_format_from_pixfmt(enum AVPixelFormat
>> pix_fmt);
>> +uint32_t av_map_videotoolbox_format_from_pixfmt(enum AVPixelFormat
>> pix_fmt, bool full_range);
>>
>>  #endif /* AVUTIL_HWCONTEXT_VIDEOTOOLBOX_H */
>
> constitutes an API change and thus requires some sort of bump?

It requires a new function, for example
"av_map_videotoolbox_format_from_pixfmt2()".

Carl Eugen