[FFmpeg-devel] [PATCH] avcodec/h264_ps: fix storage size for offset_for_ref_frame

James Almer jamrial at gmail.com
Wed Apr 10 21:30:03 EEST 2019

The spec defines the valid range of values to be INT32_MIN + 1 to INT32_MAX, inclusive.

Signed-off-by: James Almer <jamrial at gmail.com>
A good example of why making offsets and sizes of structs like this tied to the
ABI is not a good idea.

 libavcodec/h264_ps.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavcodec/h264_ps.h b/libavcodec/h264_ps.h
index e967b9cbcf..9014326dfb 100644
--- a/libavcodec/h264_ps.h
+++ b/libavcodec/h264_ps.h
@@ -81,7 +81,7 @@ typedef struct SPS {
     uint32_t num_units_in_tick;
     uint32_t time_scale;
     int fixed_frame_rate_flag;
-    short offset_for_ref_frame[256]; // FIXME dyn aloc?
+    int32_t offset_for_ref_frame[256];
     int bitstream_restriction_flag;
     int num_reorder_frames;
     int scaling_matrix_present;

More information about the ffmpeg-devel mailing list