[FFmpeg-devel] Patchwork attribution

[Hendrik Leppkes]

On Thu, Apr 18, 2019 at 12:41 PM Gyan <ffmpeg at gyani.pro> wrote:
>
>
>
> On 18-04-2019 03:25 PM, Timo Rothenpieler wrote:
> > On 18/04/2019 09:49, Gyan wrote:
> >>
> >> Patchwork can incorrectly assign ownership. See
> >> https://patchwork.ffmpeg.org/patch/12680/
> >>
> >> The author is Sam John as identified by Message ID as well as the
> >> From field in the headers, yet Patchwork attributes this patch to
> >> "Oliver Collyer via ffmpeg-devel", a name which appears nowhere in
> >> the headers or in the submitted patch. The downloaded mbox patch
> >> shows the same wrong attribution. Does anyone know what's going on?
> >>
> >> Gyan
> >> _______________________________________________
> >> ffmpeg-devel mailing list
> >> ffmpeg-devel at ffmpeg.org
> >> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >>
> >> To unsubscribe, visit link above, or email
> >> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
> >
> > This happens due to Mailman having to rewrite peoples E-Mail addresses
> > if they have strong DKIM/DMARC configured on their sending Domain.
> > If that is the case, only the server of the actual Domain who owns the
> > right private key can send E-Mails under the name of that Domain.
> >
> > So for mailing lists to be able to send on the messages, they are
> > forced to change the sender address.
> > In the case of this list:
> > Sam John <samjohn at google.com>
> > gets translated to.
> > Sam John via ffmpeg-devel <ffmpeg-devel at ffmpeg.org>
> >
>
> Ok.  Then shouldn't it assign 'Sam John via ffmpeg-devel' as the author?
> It did do that for 'Oliver Collyer via ffmpeg-devel', the string wrongly
> substituted here.
> This looks like a parser failure in Patchwork.
>

All of those patches with re-written senders are send from the same
email, ffmpeg-devel at ffmpeg.org
Presumably patchwork only sends the email itself, not the name, and as
such assumes this is the same person.

Whoever setup this ML sender rewriting thing should probably look into
options to also re-write the patch content and add a "From:" line in
there with the original name and email to avoid issues.

- Hendrik