[FFmpeg-devel] [PATCH] avformat/apetag: tag values are unsigned

James Almer jamrial at gmail.com
Fri Apr 19 19:26:16 EEST 2019

On 4/18/2019 9:56 PM, Dan Sanders via ffmpeg-devel wrote:
>>> +#define APE_TAG_FLAG_CONTAINS_HEADER  (1U << 31)
>> Isn't it enough with this one only?
> Yes, only APE_TAG_FLAG_CONTAINS_HEADER is problematic. I changed all
> of them because the tags are only used in unsigned contexts anyway.

Applied your patch changing only the above define, as the others are
unnecessary. Better for git blame as well.


More information about the ffmpeg-devel mailing list