[FFmpeg-devel] [PATCH] avformat/mpegenc - reject unsupported audio streams

Gyan ffmpeg at gyani.pro
Wed Apr 24 07:29:36 EEST 2019

On 24-04-2019 03:30 AM, Carl Eugen Hoyos wrote:
> 2019-04-22 13:00 GMT+02:00, Gyan <ffmpeg at gyani.pro>:
>> On 22-04-2019 01:15 PM, Gyan wrote:
>>> On 22-04-2019 12:30 PM, Carl Eugen Hoyos wrote:
>>>>> Am 20.04.2019 um 11:31 schrieb Gyan <ffmpeg at gyani.pro>:
>>>>> Old patch that was never applied. Rebased.
>>>> Please return patch_welcome for mlp and truehd.
>>> Will do.
>>>> Wasn’t there another comment (not by me): “Why
>>>> can’t .codec_tag be used?”
>>> There's no codec_tag member set. This patch is just
>>> to disallow an invalid muxing to proceed.
> Wasn't the argument that this is possible with codec_tag?

Not in the present state. If you want to add a codec_tag, that's a 
separate patch.

>> Revised.
> What about aac?

There's no provision to mux AAC, at present. On demux, the stream is 
detected as mp2.

> And can't you wait more than a few hours for a review?
This patch is 14 months old, except for the one change you requested. 
And all the patch does is enforce the existing limitations.


More information about the ffmpeg-devel mailing list